-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escalating background tasks "overriding microprofile classpath" causing high load and stalling builds #1190
Comments
@angelozerr oh, I really tried to find this issue :) Thanks for the pointer, I'll watch that issue then! |
@E14 it is very hard to reproduce it since this override of classpath with Quarkus deploiement (to retrieve Quarkus properties from deploiement JAR) reacts when library changed with some debounce. If you have no luck you encounter this so awfull performance problem. We already tried to fix this issue with the PR #1080 but it degrades performance of Quarkus properties compute. I have some ideas but it is not trivial. Let's me finishing #1188 and after that I will work on this issue. |
@E14 I have a draft PR #1221 which should improve the Quarkus deployment support :
To reproduce your isse, you add a depndency in pom.xml and you refresh your pom.xml and you do that several times. You should see your issue. With my draft PR #1221, I cancel the Quarkus deployment process as soon as there is a classpath changes. |
Indeed I'm working on #1221 but just for the test, so I think you can test it by downloading IJ Quarkus zip at https://github.com/redhat-developer/intellij-quarkus/actions/runs/6532134435 and followthe instruction at https://github.com/redhat-developer/intellij-quarkus#testing-the-ci-builds It should be really nice if you could install it and give us feedback. Thanks! |
|
@fbricon I noticed the last few days that the "maven pom reload" button sometimes does not appear anymore, could that be a result of this change? I'm still running the build you gave me |
Not sure but I doubt it. We're not touching anything close to the Maven config. I also saw the button not show up, but it's been happening for a very long time for me. So unlikely this is caused by this particular fix. BTW 1.29.0 has been released on the marketplace yesterday |
@fbricon so, I monitored this for a while now, and this still happens with the release version, but not regularly. The reason I suspected this change is because of this:
I was concerned that the "cancel" also prevents further actions, like marking the project as requiring a rebuild when that happens. When this happens it also seems to affect other build items, eg. I deleted a test case (class), and afterwards it would still find the testcase when running the |
@E14 I think it should be better to process the quarkus deployment only when project is imported and not when librairies changed. I have implemented this project import listener for the auto create Quarkus run config, I will try it to use this listener for deployment. |
@angelozerr I'm sorry I just saw that I mentioned the wrong user previously Anyway, I'm not certain that this change is the cause, this is much less researched than the original issue (I assume due to the overall much improved build process? 🙂👍) and I haven't had any luck debugging this, there are no error messages or other indicators, so unless you are certain -- Is there any way to enable debug logging? That could help me find out more. Sadly, depending on what you change in the pom however, and what you need from it in the plugin, a pom change might very well require tooling reload (Quarkus version change, adding/removing Quarkus dependencies, shared dependency change, etc.) |
For some time I'm seeing an issue where the "Overriding MicroProfile classpath...." ~ "Collecting Quarkus deployment dependencies" background task
These may be related to having multiple IntelliJ projects open at the same time.
When this situation starts, an additional background process is started basically every time any source (and I think resource) file is saved.
Please let me know if any additional data is needed to resolve this, sadly I don't know how to reproduce the behaviour as it happens sporadically.
The text was updated successfully, but these errors were encountered: