Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to know that my multi-resource editor successfully created the resource #710

Open
adietish opened this issue Jan 12, 2024 · 0 comments · May be fixed by #800
Open

As a user I want to know that my multi-resource editor successfully created the resource #710

adietish opened this issue Jan 12, 2024 · 0 comments · May be fixed by #800
Assignees
Milestone

Comments

@adietish
Copy link
Collaborator

adietish commented Jan 12, 2024

related to #658

In #658 we re-introduced the notification for a single-resource editor which tells the user that the resource was successfully created.
We're still missing this for the multi-resource editor.

Steps:

  1. EXEC: open the following in an editor:
kind: Deployment
apiVersion: apps/v1
metadata:
  name: numberguess
spec:
  replicas: 1
  selector:
    matchLabels:
      app: numberguess
  template:
    metadata:
      labels:
        app: numberguess
    spec:
      containers:
        - name: my-numberguess
          image: numberguess:latest
          ports:
            - name: http
              containerPort: 8081
              protocol: TCP
          resources:
            limits:
              memory: "1024Mi"
              cpu: "500m"
---
kind: Service
apiVersion: v1
metadata:
  name: numberguess-svc
spec:
  ports:
    - name: http-8081
      port: 8081
      protocol: TCP
      targetPort: 8081
  selector:
    app: numberguess
  1. EXEC: push the editor to the cluster
  2. ASSERT: the resources were successfully created

Result:
Nothing happens. There's no notification that tells you that the resource were successfully created. You only get a notification if something goes wrong and resources could not get created

Expected result:
I want to be informed that the resources were created on the cluster. Of course I'd also like to know of errors. So the notification should inform of both: success and errors. It's currently not evident how to inform properly as notifications currently only have single line and a single icon: they either inform of success (for the single resource editor) or errors (for both, the single resource editor or the multi resource editor)

@adietish adietish assigned adietish and unassigned adietish Jan 12, 2024
@adietish adietish added this to the Backlog milestone Jan 12, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 14, 2024
@adietish adietish moved this to 📝 In Progress in IDE Cloudaptors Oct 14, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 15, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Oct 15, 2024
@adietish adietish self-assigned this Oct 16, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Nov 7, 2024
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant