New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor output format framework to support tables and empty format #1502

Closed

gowriswarupk wants to merge 86 commits into redhat-developer:main from gowriswarupk:sdpcommandedit

Contributor

gowriswarupk commented Mar 31, 2022 •

edited by wtrocki

Loading

Motiviation

Addressing issue #1429

Changes made:

fix:Kafka topic creation command "mute" successful. [1]
chore: Artifact rules enable --config should only propose values for specific rule [2]

Verification Steps:

for fix [1] :
./rhoas kafka topic create --name=kannan --output=none


          [WIP] [Updated] Issues #1429 and #1440

979f071

redhat-developer deleted a comment from gowriswarupk

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/ioutil/dump/dump.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/ioutil/dump/dump.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved


          Merge branch 'redhat-developer:main' into sdpcommandedit

7456a23

openshift-ci bot added the do-not-merge/work-in-progress label

Kannan and others added 5 commits

April 5, 2022 11:17


          [WIP] [Updated]: Issues #1429 and #1440

d6242d9


          chore: bazzinga

ffd911e


          chore: updated fix #1502

106a18d


          chore: updated issue #1502

e3d67f5


          fix: issue #1429 completed, awaiting verification

ce01938

gowriswarupk changed the title ~~[WIP]: Issues #1429 and #1440~~ Chore: Issues #1429 and #1440

openshift-ci bot removed the do-not-merge/work-in-progress label

wtrocki requested a review from rkpattnaik780

April 7, 2022 09:49

rkpattnaik780 requested changes

View reviewed changes

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

pkg/core/cmdutil/flagutil/flagset.go Outdated Show resolved Hide resolved

pkg/core/ioutil/dump/dump.go Show resolved Hide resolved

wtrocki changed the title ~~Chore: Issues #1429 and #1440~~ Refactor output format framework to support tables and empty format


          fix: support for tables and empty format

2e913a2

wtrocki reviewed

View reviewed changes

pkg/cmd/kafka/acl/list/list.go Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/cmd/registry/artifact/role/list/list.go Outdated Show resolved Hide resolved


          chore: configure list.go to include table

d1e4d95

wtrocki reviewed

View reviewed changes

pkg/cmd/kafka/acl/list/list.go Outdated Show resolved Hide resolved

wtrocki reviewed

View reviewed changes

pkg/cmd/kafka/acl/list/list.go Outdated Show resolved Hide resolved

Kannan added 2 commits

April 12, 2022 14:45


          chore: updated list.go(s)

02d2057


          chore: updated fix for #1429 and .md files

86d5edf

wtrocki and others added 27 commits

April 25, 2022 12:09


          fix: move messages generator

b0d6d74


          fix: add connectors to root

1795e90


          fix: add example strings

a36cb62


          fix: improve messages

ea82d7e


          fix: add parameters

1d70446


          fix: add create support

80550c9


          fix: use default page size from build

c691896


          fix: remove invalid char in docs

c1faa46


          fix: map connector status to row (#1518)

ff5eee3


          feat(connector): add update and namespace commands

d0784e3


          fix: update client to enable using external clients

f0a21a2


          fix: expose api config to enable using external clients and APIs (#1523)

0dae5ae


          feat(connectors): add update cmd and enhance commands


          refactor(connector): rename connectors to connector

adbf41c


          feat(connector namespace): add delete command and refactors

0a516e5


          docs(context): format toml file and change helper text

a4977b0


          refactor(connector): move addon param to cluster cmd

d94eb50


          fix: build failing at lint

0b9cffa


          fix(connector): hide connector commands

c328b0b


          fix(connector namespace): add validation

eff3724


          feat(service-registry): display compatibile API endpoints

0b4bdce


          fix: address review comments

33ca6e8


          fix: change to info from error

3f643cf


          fix: change message for compatibility APIs

e9ffbaa


          docs(connector update): change erroneous message

0d5ee3e


          chore: update CHANGELOG

342c60c


          chore: update and fix issues

0f2f8e1

Contributor

rkpattnaik780 commented Apr 26, 2022

Needs rebase

Collaborator

wtrocki commented Apr 26, 2022

git rebase -i origin/main

fixup as many commits as you can leaving only first one.
I have tried that and I managed to get conflicts only once.

gowriswarupk closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet