Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unavailable regions should not show in --region completion values in kafka create #1460

Open
craicoverflow opened this issue Feb 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@craicoverflow
Copy link
Contributor

Description

Version: 0.39.0

The user that I am logged in as can either create eval Kafka instances or standard ones. Not all regions are available for all instance types. In interactive mode unavailable regions are filtered out, but these still show up for completions.

Steps to reproduce

Run rhoas kafka create and select eu-west as your region, which is invalid. We should not show this as a valid value.

$ rhoas kafka create --provider aws --region
eu-west-1  us-east-1

Solution

The same function should be used in both scenarios to ensure data consistency.

Screenshots

Screenshot 2022-02-23 at 15 30 06

Screenshot 2022-02-23 at 15 31 53

@craicoverflow craicoverflow added bug Something isn't working good first issue Good for newcomers labels Feb 23, 2022
@wtrocki wtrocki self-assigned this Apr 6, 2022
@wtrocki
Copy link
Collaborator

wtrocki commented Apr 21, 2022

I have implemented that but needed to temporary disable this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants