Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries for DatabaseSecretEngineStaticRole are too aggressive #114

Open
ameyp opened this issue Jan 14, 2023 · 5 comments
Open

Retries for DatabaseSecretEngineStaticRole are too aggressive #114

ameyp opened this issue Jan 14, 2023 · 5 comments

Comments

@ameyp
Copy link
Contributor

ameyp commented Jan 14, 2023

If reconciliation for DatabaseSecretEngineStaticRole fails (because the database is unreachable, on because the password is wrong), it is retried once every 4-5 seconds. I think this retry is too aggressive, and we should perhaps implement a backoff on failures. For example, retry after 5 seconds, then 10, then 20, then 40, all the way up to maybe 5 minutes.

@raffaelespazzoli
Copy link
Collaborator

this is weird. I'm using the default retry policy for operator which should be incremental retry period (doubling it every time) up to a max of about 6 minutes. Pretty much like pods do...

@raffaelespazzoli
Copy link
Collaborator

could you re-test after #118 is merged?

@ameyp
Copy link
Contributor Author

ameyp commented Feb 6, 2023

Sure, will re-test after that's merged

@raffaelespazzoli
Copy link
Collaborator

can we close this?

@ameyp
Copy link
Contributor Author

ameyp commented Mar 2, 2023

Tried with latest commit on main, still happening for static roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants