This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
feat(STONEINTG-892): Include git url override snapshot example #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source key in the snapshot also the git url as well as the revision. This is a small followup fix for redhat-appstudio#274. Not sure if there's a preferred name for example github urls, but feel free to tweak it as you like.
Revise the explanation for the 'source' key to hopefully avoid some people having unexpected problems getting their EC check to pass after creating an override snapshot. (Could be squashed with last commit if preferred.)
|
FYI @hongweiliu17 @dirgim |
|
🚀 Preview is available at https://pr-276--boisterous-meerkat-894982.netlify.app |
simonbaird
added a commit
to simonbaird/integration-examples
that referenced
this pull request
Jun 27, 2024
|
See also konflux-ci/integration-examples#33 . |
dirgim
pushed a commit
to konflux-ci/integration-examples
that referenced
this pull request
Jun 28, 2024
lcarva
approved these changes
Jul 17, 2024
|
The redhat-appstudio docs are deprecated. Would you be able to recreate a similar PR on konflux-ci/docs? |
Already done over there, see konflux-ci/docs#74 |
|
Great! Let's close this out then? |
|
@arewm merge maybe? |
|
I have no permissions on this repository, unfortunately. |
|
I seem to have the permissions, I will merge this to keep consistency with the konflux-ci/docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the git url as well as the revision, and add some additional explanation about the source key. (Commit messages have some additional notes.)
This is a followup for #274.
See also KFLUXBUGS-1376.
STONEINTG-892