From a8ff0a001ecea3d23f9250f2590074d30799fd56 Mon Sep 17 00:00:00 2001 From: Simon Baird Date: Thu, 27 Jun 2024 15:21:44 -0400 Subject: [PATCH 1/2] feat(STONEINTG-892): override snapshot git url The source key in the snapshot also the git url as well as the revision. This is a small followup fix for #274. Not sure if there's a preferred name for example github urls, but feel free to tweak it as you like. --- .../testing_applications/proc_creating_override_snapshot.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc b/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc index 02d39ada..93c7056a 100644 --- a/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc +++ b/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc @@ -34,6 +34,7 @@ spec: containerImage: quay.io/redhat-user-workloads/ws-sample-tenant/application-sample/component-sample@sha256:0db0a473a6abf5c15c424ab07cfbd5c40c06622fe648d4fe6a6b6abc224a0d0c <3> source: <4> git: + url: https://github.com/sample-org/sample-repo revision: fa8b89274a61ef0f1c257b7a84c37aa2ec844109 ---- <1> The label `test.appstudio.openshift.io/type: override` that indicates this is an `override` snapshot. From e445fd084e3b9b73e03e39455c9044ed6fcad81f Mon Sep 17 00:00:00 2001 From: Simon Baird Date: Thu, 27 Jun 2024 15:28:17 -0400 Subject: [PATCH 2/2] feat(STONEINTG-892): Override source explanation Revise the explanation for the 'source' key to hopefully avoid some people having unexpected problems getting their EC check to pass after creating an override snapshot. (Could be squashed with last commit if preferred.) --- .../testing_applications/proc_creating_override_snapshot.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc b/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc index 93c7056a..81c44eb4 100644 --- a/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc +++ b/docs/modules/ROOT/pages/how-to-guides/testing_applications/proc_creating_override_snapshot.adoc @@ -40,7 +40,7 @@ spec: <1> The label `test.appstudio.openshift.io/type: override` that indicates this is an `override` snapshot. <2> The component name you will reset its Global Candidate List. <3> The container image with valid digest you will reset the component <2> to. -<4> Optional. The component source containing the git revision. +<4> Optional, but may cause an Enterprise Contract check to fail if it's incorrect or missing. The component source containing the git url and revision that the container image was built from. . Save the .yaml file and add the snapshot.yaml by running the following command: