From 05a370d627e164458a3490700b6e441e8686717e Mon Sep 17 00:00:00 2001
From: Andrew Ballantyne <aballant@redhat.com>
Date: Tue, 24 Oct 2023 15:51:30 -0400
Subject: [PATCH] Dashboard 2.4 manifests updates

---
 odh-dashboard/apps/base/jupyter/jupyter-app.yaml      |  2 +-
 odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml   |  2 +-
 odh-dashboard/base/cluster-role.yaml                  |  8 ++++++++
 .../crd/acceleratorprofiles.opendatahub.io.crd.yaml   | 11 ++++++++++-
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/odh-dashboard/apps/base/jupyter/jupyter-app.yaml b/odh-dashboard/apps/base/jupyter/jupyter-app.yaml
index 645d9987b..34f9c8ae5 100644
--- a/odh-dashboard/apps/base/jupyter/jupyter-app.yaml
+++ b/odh-dashboard/apps/base/jupyter/jupyter-app.yaml
@@ -170,7 +170,7 @@ spec:
   kfdefApplications:
     - odh-notebook-controller
     - notebook-images
-  support: redhat
+  support: red hat
   provider: Jupyter
   docsLink: 'https://jupyter.org'
   quickStart: create-jupyter-notebook
diff --git a/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml b/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml
index 4513aaf46..abefbef61 100644
--- a/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml
+++ b/odh-dashboard/apps/base/jupyter/jupyterhub-app.yaml
@@ -84,7 +84,7 @@ spec:
       </g>
     </svg>
   category: Red Hat managed
-  support: redhat
+  support: red hat
   docsLink: https://jupyter.org/hub
   quickStart: create-jupyter-notebook
   getStartedLink: https://jupyterhub.readthedocs.io/en/stable/getting-started/index.html
diff --git a/odh-dashboard/base/cluster-role.yaml b/odh-dashboard/base/cluster-role.yaml
index d21d47cd0..228eaeed7 100644
--- a/odh-dashboard/base/cluster-role.yaml
+++ b/odh-dashboard/base/cluster-role.yaml
@@ -164,3 +164,11 @@ rules:
       - delete
     resources:
       - notebooks
+  - apiGroups:
+      - datasciencecluster.opendatahub.io
+    verbs:
+      - list
+      - watch
+      - get
+    resources:
+      - datascienceclusters
diff --git a/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml b/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml
index 568497e53..56b11b73f 100644
--- a/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml
+++ b/odh-dashboard/crd/acceleratorprofiles.opendatahub.io.crd.yaml
@@ -28,14 +28,19 @@ spec:
               properties:
                 displayName:
                   type: string
+                  description: "The display name of the accelerator profile."
                 enabled:
                   type: boolean
+                  description: "Indicates whether the accelerator profile is available for new resources."
                 identifier:
                   type: string
+                  description: "The resource identifier of the accelerator device. Example: nvidia.com/gpu"
                 description:
                   type: string
+                  description: "A short description of the accelerator profile."
                 tolerations:
                   type: array
+                  description: "Any number of Kubernetes toleration values that are added to resources when created or updated to this accelerator profile."
                   items:
                     type: object
                     required:
@@ -43,12 +48,16 @@ spec:
                     properties:
                       key:
                         type: string
+                        description: "Taint key. Empty matches all keys."
                       operator:
                         type: string
+                        description: "Relationship with the value. Valid: 'Exists', 'Equal'. Defaults to 'Equal'."
                       value:
                         type: string
+                        description: "Tolerance value. If key is empty, use 'Exists' to match all values and keys."
                       effect:
                         type: string
+                        description: "Taint effect. Empty matches all effects. Allowed: 'NoSchedule', 'PreferNoSchedule', 'NoExecute'."
                       tolerationSeconds:
                         type: integer
-   
\ No newline at end of file
+                        description: "Duration in seconds. If effect is 'NoExecute', specifies eviction time. Default is forever."
\ No newline at end of file