Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from opendatahub-io:main #372

Closed
wants to merge 67 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 29, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 29, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -5,7 +5,7 @@
"datascience"
],
"display_name": "Datascience with Python 3.8 (UBI8)",
"image_name": "quay.io/opendatahub/workbench-images@sha256:471386969e54c287e3d1777479d1e8b05f1e07b824cc2c1ec98d29ac5006b378",
"image_name": "quay.io/opendatahub/workbench-images@sha256:a4290926fbfa8c54825ab867b7201c11be8c676a96d4811fdb3a8f1e348d3eb0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this diff very much. It states that the only change on this line is the hash of the image. Yet current content of that line uses an image from the modh repository as expected https://github.com/red-hat-data-services/notebooks/blob/main/jupyter/datascience/anaconda-python-3.8/runtime-images/datascience-ubi8-py38.json#L8 .

We don't want to have images from opendatahub image repo in the downstream codebase.

@pull pull bot added the needs-rebase label Aug 29, 2024
harshad16 and others added 6 commits September 6, 2024 16:47
Bump `codeflare-sdk` to version `0.19.1` for Python 3.11 images
- Update TrustyAI to 0.6.1 (adds support for TMaRCo local models)
- Add PyTorch, transformers, datasets and accelerate as TrustyAI notebook image dependencies
dibryant and others added 28 commits September 26, 2024 05:06
* Pin kfp to the latest 2.5.0 release

* Pin the pipfile.lock for the rocm-tensorflow

Signed-off-by: Harshad Reddy Nalla <[email protected]>

---------

Signed-off-by: Harshad Reddy Nalla <[email protected]>
Co-authored-by: Harshad Reddy Nalla <[email protected]>
Issue #713: fix(gha): don't crash when branch name matches file name in the repo
Upgrade R version to 4.4 for the 2024b
Update the amd manifest with 2024b and python 3.11
Upgrade cuda drivers from 12.1 to 12.4
Fix NVARCH env to point on x86_64
From now on the images build on this branch are named with 2024b infix
in their tags.

Helps to move the [1] further.

* [1] https://issues.redhat.com/browse/RHOAIENG-12621
Bump the release version of the build images from 2024a to 2024b
chores: set the python 3.11 content for refresh-pipfile-lock cmd in Makefile
Updated odh-elyra from 4.0.0.dev1 to 4.0.0rc0
Upgrade Notebook with codeflare-sdk version 0.21.1
- Fix codeserver extension typo
- Update Code Server to version 4.92.2
- Add instructions to run Code Server containers and how to update extensions
- Minor change in extensions README instructions
- Update extensions and add instructions on how to update extensions in the repository
Patch TensorFlow Pipfile to download its own cuda version GPU
Updated the notebook manifests with 2024b image reference
#716)

* Update of workbench images and runtime images digest updater GHAs

This is for [1].

* [1] https://issues.redhat.com/browse/RHOAIENG-12621

* Small improvements for the runtime digest updater GHA.

* Update GHA for digest updaters to be closer the content in downstream

Just some formatting so that the code is similar to what is in
downstream for easier comparability.

* DONT COMMIT this one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants