Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] sync main from opendatahub-io:main #364

Merged
merged 26 commits into from
Aug 29, 2024

Conversation

harshad16
Copy link
Member

Fixes: #359

sync main from opendatahub-io:main
this covers all the commits from opendatahub-io:main

created with following commands:

git checkout main
git checkout -b rsync-main
git remote add upstream <opendatahub-io/notebooks>
git pull upstream main --no-rebase

atheo89 and others added 25 commits August 12, 2024 15:22
…ct-runtimes

Inject rocm runtimes to runtime-images folder
RHOAIENG-10972: Create a script to automate library upgrades
…ased image from an existing one (opendatahub-io#672)

* Add script to automate the creation of a new Python-based image from an existing one

* Add type annotations to function args

* Add missing folders to blocklist

* Removing redundant comment

* Use dataclass in the Args class

* Use context manager for logged_execution

* Set encoding prop on subprocess.run

* Improve log level help message

* Return non-zero code for non-happy scenarios

* Add type annotations to function return

* Final adjustments

* Code review request
RHOAIENG-11300: Improve the library upgrade script for alternative sources
…-ref

Fix reference to quay.io/repository/opendatahub on README file
* Add images based on python 3.11

* Apply opendatahub-io#656 to Python 3.11 images

* Fix expected TF vesion on the test file

* Fix labels for Python 3.11

* Apply opendatahub-io#652 to Python 3.11 images

* Update lock to fix debugpy package version

* Apply opendatahub-io#635 to Python 3.11 images

* Replace 3-9 -> 3-11 leftovers

* Fix runtime rocm image name according to openshift/release

* Apply opendatahub-io#667 to Python 3.11 images

* Adapt test code for Python 3.11 images
…-updater-10418058789

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.19.1
Updated image manifests with AMD images for pytorch and tensorflow
Recently the kustomize test started to fail for us since the kustomize
version 5.4 introduced some breaking changes for which we will need to
update our manifests to be compatible. This work will be tracked in [1].
In the meantime, we should pin kustomize version in our GHA to the
version that is used by the opendatahub-operator in runtime [2].

[1] https://issues.redhat.com/browse/RHOAIENG-11679
[2] https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.12/go.mod#L30-L31
[GHA] Pin kustomize version we use in our test to the particular version
Update the codeflare-sdk version in manifest for the relevant images
Update runtime updater workflow to search for the  new ROCm runtimes
Use the correct way of ROCm brand in user facing content
RHOAIENG-11090: Create a script to automate multiple library upgrades
Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member

Seems like one extra commit is needed here (not sure why it differs from upstream, though - @jiridanek ?):

Error: Please run 'bash ci/generate_code.sh' (the command from the previous step), commit the changed files locally, and push again.

@jiridanek
Copy link
Member

I guess just syncing everything does not apply cleanly, see

@jiridanek
Copy link
Member

/lgtm

@jstourac
Copy link
Member

/lgtm

Though, the GH states this still has some conflicts even though no new commit was added to the main branch in the past 2 days 🤔

@atheo89 atheo89 merged commit 217444c into red-hat-data-services:main Aug 29, 2024
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants