forked from opendatahub-io/notebooks
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-11087: Remove the installation of packages from bootstrapper.py #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pytorch (opendatahub-io#652) * RHOAIENG-9853: fix(rocm): de-vendor the bundled rocm libraries from pytorch Use the script from instructlab to remove the duplicate copy of rocm libs from the image. This will make the image significantly smaller. Script lives at https://github.com/tiran/instructlab-containers/blob/main/containers/rocm/de-vendor-torch.sh * add a selftest
chore(ci): Re-enable Trivy image scan for ROCm Pytorch image
…efile and allow skipping building dependent images (opendatahub-io#657) Co-authored-by: Guilherme Caponetto <[email protected]>
…the preceding RUN when possible (opendatahub-io#635) * RHOAIENG-9853: fix(Dockerfiles): combine fix-permissions RUN with the preceding RUN when possible * fixup, be more aggressive on the rocm buildchain * fixup, forgotten RUN * fixup, unify slashes * fixup, unify indent
[GHA] Print also images digests after the image build in GitHub repo
…installed Signed-off-by: Harshad Reddy Nalla <[email protected]>
…ackage RHOAIENG-11087 Fix: Remove install of package in bootstrapper as pre-installed
[pull] main from opendatahub-io:main
…09839691 [Digest Updater Action] Update Runtime Images
…13212251 [Digest Updater Action] Update Notebook Images
Merging to get the blocker fixed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/RHOAIENG-11087
These commits are the one that brings the fixes:
Commit with code change: d30b6e6
Commit for runtime image: 909743a
Commit for notebook image: 9b0d18a, 9b2a721
The rest of the commits are just CI changes and have no code changes.