Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11087: Remove the installation of packages from bootstrapper.py #356

Merged
merged 15 commits into from
Aug 9, 2024

Conversation

harshad16
Copy link
Member

Fixes: https://issues.redhat.com/browse/RHOAIENG-11087

These commits are the one that brings the fixes:
Commit with code change: d30b6e6
Commit for runtime image: 909743a
Commit for notebook image: 9b0d18a, 9b2a721

The rest of the commits are just CI changes and have no code changes.

jiridanek and others added 15 commits August 6, 2024 09:15
…pytorch (opendatahub-io#652)

* RHOAIENG-9853: fix(rocm): de-vendor the bundled rocm libraries from pytorch

Use the script from instructlab to remove the duplicate copy of rocm libs from the image.
This will make the image significantly smaller.
Script lives at https://github.com/tiran/instructlab-containers/blob/main/containers/rocm/de-vendor-torch.sh

* add a selftest
chore(ci): Re-enable Trivy image scan for ROCm Pytorch image
…efile and allow skipping building dependent images (opendatahub-io#657)

Co-authored-by: Guilherme Caponetto <[email protected]>
…the preceding RUN when possible (opendatahub-io#635)

* RHOAIENG-9853: fix(Dockerfiles): combine fix-permissions RUN with the preceding RUN when possible

* fixup, be more aggressive on the rocm buildchain

* fixup, forgotten RUN

* fixup, unify slashes

* fixup, unify indent
[GHA] Print also images digests after the image build in GitHub repo
…ackage

RHOAIENG-11087 Fix: Remove install of package in bootstrapper as pre-installed
[pull] main from opendatahub-io:main
…09839691

[Digest Updater Action] Update Runtime Images
…13212251

[Digest Updater Action] Update Notebook Images
@harshad16
Copy link
Member Author

Merging to get the blocker fixed.
/approve

Copy link

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2024
@harshad16 harshad16 merged commit 4c7e4f9 into rhoai-2.12 Aug 9, 2024
75 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants