-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single build system #255
Comments
Hi @Chris-F5 , Thanks for the feedback, let's get more feedback for this. |
MSBuild at least can just be generated by either Meson or CMake, so it's probably not very important to keep. Also handwritten XML is going to be the hardest thing to keep up to date anyway. Like cmake's support for add_subdirectory on another cmake project, there's one particular advantage to having meson support in that you can embed it as a subproject inside your own meson-using project and it "just works". This is described in the README the same way it's described for cmake.
Different hashes can be caused by using different file paths when referencing the source files, that's not really a good proof of anything. Looking at differences in the compiler invocations in build.ninja or compile_commands.json should tell you all you need to know there. |
@eli-schwartz thanks for your feedbacks 👍 |
The autotools build is currently broken (the built cglm.pc includes placeholders). |
not sure if applicable, one way I have seen this addressed is to add build steps on CI to build in all supported build systems. |
@masters3d sure hope we update CIs to cover all build systems 👍 |
I've submitted #386 which adds a bunch of CI. |
At the moment,
cglm
can be built with the following build systems:It is not realistic to expect developers to check that
cglm
compiles correctly on all 5 build systems before making a pull request. So if a change breaks one build system, it is possible that the problem will go unnoticed.Building with different systems can result in different
libcglm.so
files (building with CMake and Meson generatelibcglm.so
with different hashes). If a bug only occurs when building with a specific build system then it could be very difficult to find.For these reasons, it would be better to use only a single build system. I think CMake would be most appropriate as its cross platform and because
glm
uses it.I would be happy to make a pull request for this change if a single build system can be agreed upon.
The text was updated successfully, but these errors were encountered: