Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get testing of built Docker image working in CI #50

Open
matthewfeickert opened this issue Sep 20, 2021 · 1 comment
Open

Get testing of built Docker image working in CI #50

matthewfeickert opened this issue Sep 20, 2021 · 1 comment

Comments

@matthewfeickert
Copy link
Member

this seemss to be too deeeply nested docker (note it mounts docker.sock which might not be avaliable on GHA). c.f. maxheld83/ghactions#307

Originally posted by @lukasheinrich in #46 (comment)

@matthewfeickert
Copy link
Member Author

Ah, as a note to myself on understanding how recast is running Docker in Docker, it is mounting the socket /var/run/docker.sock

command = [
"docker",
"run",
"--rm",
"-i",
"-v",
"{}:{}".format(cwd, cwd),
"-w",
cwd,
"-v",
"/var/run/docker.sock:/var/run/docker.sock",
]

and so relying on the host to provide Docker. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant