You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great to provide ~graphiql: bool option to Morph_graphql_server.make or provide something like Morph.Response.text(Library.GraphiQL.html, Morph.Response.empty) available from Morph_graphql_server module
I added GraphiQL as it was the easiest and quickest, but worth considering whether one should allow this to be a bit more configurable. Should it just be a url or should it just be yet another middleware? @ulrikstrid
I think that this is a documentation problem basically. I like that graphiql (or any derivative) is provided in the pesy template because it's really powerful to have there. But I'm not sure we want to integrate it into the the library.
I'm not against it, I'm just not sure we want to do it since it can feel like "lock in" to that particular implementation. We also have to keep it up to date.
It would be great to provide
~graphiql: bool
option toMorph_graphql_server.make
or provide something likeMorph.Response.text(Library.GraphiQL.html, Morph.Response.empty)
available fromMorph_graphql_server
module/ cc @cem2ran
The text was updated successfully, but these errors were encountered: