Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra blank lines with OCaml 5.1 (alpha) #429

Open
talex5 opened this issue May 25, 2023 · 0 comments
Open

Extra blank lines with OCaml 5.1 (alpha) #429

talex5 opened this issue May 25, 2023 · 0 comments

Comments

@talex5
Copy link
Contributor

talex5 commented May 25, 2023

Some of the Eio MDX tests were failing with OCaml 5.1 due to extra blank lines appearing in the output. It seems to be related to hidden deprecation warnings. Here's a simple test-case:

```ocaml
module F : sig
  val x : unit [@@ocaml.deprecated "Hmm"]
end = struct
  let x = ()
end

let x = F.x
```

```ocaml
# print_endline "foo";;
- : unit = ()
```

With OCaml 5.0, this produces:

# print_endline "foo";;
foo
- : unit = ()

But with 5.1 we get an extra blank line:

# print_endline "foo";;
foo

- : unit = ()
talex5 added a commit to talex5/eio that referenced this issue May 25, 2023
Using `Fmt.unit` causes blank lines to appear in the output!
See: realworldocaml/mdx#429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant