Make unroll-stacktrace ndk_stack resolution more robust #7044
Conversation
| @@ -48,7 +48,8 @@ find_ndkstack() { | |||
| echo "$PROPS_FILE not found! NDK location cannot be determined" | |||
| exit 1 | |||
| fi | |||
| NDK_STACK=$(grep "ndk.dir" "$PROPS_FILE" | cut -d = -f2)/ndk-stack | |||
| NDK_STACK=$(grep "^ndk.dir" "$PROPS_FILE" | cut -d = -f2)/ndk-stack | |||
| which $NDK_STACK || { echo "Could not find 'ndk_stack' at $NDK_STACK"; exit ;} | |||
There was a problem hiding this comment.
Good idea, but this doesn't work for me unless I remove this line set -euo pipefail . I don't remember why I added that to be honest, so probably safe to remove.
But it also looks like we need a new way to find ndk-stack. With the new NDK the default location seems to be $sdk_dir/ndk-bundle/prebuilt/darwin-x86_64/bin/ndk-stack
There was a problem hiding this comment.
Which version of NDK is in $sdk_dir/ndk-bundle/prebuilt/darwin-x86_64/bin/ndk-stack. All my downloaded versions including latests 21.3.6528147 except are in $sdk_dir/ndk/<version>.
In my end it just failed due to multiple ndk.dir entries - some commented out. Sounds a bit to dangerous to remove the set -euo pipefail, as it probably catches some corner cases that we do not think off/test right now. Maybe it just fails in your end due to different NDK location?
There was a problem hiding this comment.
Good question actually. You are right, it is probably safer to use the one under ndk/version.
The problem I had with set -euo pipefail set, was that it swallowed the errors printed out. So the echo you added above was never printed.
No description provided.