Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versions/update): various edge cases #965

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jan 29, 2024

🚥 Resolves https://github.com/readmeio/readme/pull/10989

🧰 Changes

Client-side fixes for https://github.com/readmeio/readme/pull/10989:

  • Always includes version in body payload for PUT /version requests
  • When updating stable version, certain flag prompts (hidden, deprecated) are now properly skipped since it's impossible to set those flags on the stable version.

🧬 QA & Testing

Added more test coverage to ensure that these edge cases are accounted for.

@kanadgupta kanadgupta added bug Something isn't working command:versions Issues pertaining to the `versions` commands labels Mar 7, 2024
@kanadgupta kanadgupta marked this pull request as ready for review March 7, 2024 14:24
@kanadgupta kanadgupta merged commit 580e307 into next Mar 7, 2024
9 checks passed
@kanadgupta kanadgupta deleted the version/update-fixes branch March 7, 2024 14:25
kanadgupta pushed a commit that referenced this pull request Mar 7, 2024
# [9.0.0-next.12](v9.0.0-next.11...v9.0.0-next.12) (2024-03-07)

### Bug Fixes

* **versions/update:** various edge cases ([#965](#965)) ([580e307](580e307))

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command:versions Issues pertaining to the `versions` commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant