Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): import schemas in the types file as types #815

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Nov 8, 2023

🧰 Changes

Because all of the schemas that we're importing in codegen'd types.ts files are for types only we can import them explicitly as types.

@erunion erunion added enhancement New feature or request area:api Issues related to the `api` CLI, which builds the SDKs labels Nov 8, 2023
@erunion erunion marked this pull request as ready for review November 8, 2023 01:42
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to be a fine change according to my testing but
i don't think i understand why... technically speaking, aren't the schemas in schemas.ts actually JSON schema objects as consts?

@erunion
Copy link
Member Author

erunion commented Nov 8, 2023

they are but they're used in types.ts as only types

@erunion erunion merged commit 2aa1a45 into main Nov 8, 2023
6 checks passed
@erunion erunion deleted the feat/import-schemas-as-types branch November 8, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Issues related to the `api` CLI, which builds the SDKs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants