Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support defaults for required arrays #748

Open
cfm opened this issue Sep 29, 2023 · 1 comment
Open

support defaults for required arrays #748

cfm opened this issue Sep 29, 2023 · 1 comment
Labels
area:core Issues related to `core`, which is the package that powers the SDKs at runtime help wanted Extra attention is needed

Comments

@cfm
Copy link

cfm commented Sep 29, 2023

In cfm/ta-attendance-tools#66, I believe I'm encountering the case not handled in:

it.todo('should be able to handle arrays with defaults');

I've taken a stab at this in cfm/api@18115a3, but doesn't seem to be so straightforward after all. :-) If you can give guidance on how you'd like to see this support implemented, I'd be glad to work on it.

@erunion erunion added this to the v7 milestone Oct 6, 2023
@erunion erunion added help wanted Extra attention is needed area:core Issues related to `core`, which is the package that powers the SDKs at runtime labels Oct 12, 2023
@erunion erunion removed this from the v7 milestone Oct 16, 2023
@erunion
Copy link
Member

erunion commented Oct 19, 2023

@cfm I took a stab at this myself this week and I think we're going to have to completely rewrite how getJSONSchemaDefaults works because it currently doesn't keep track of parental default lineage. We actually fixed this same problem in our closed source API Explorer software on ReadMe customer sites and it might be worth refactoring that work out somewhere into our oas library so it can be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Issues related to `core`, which is the package that powers the SDKs at runtime help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants