-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPUB3 Bindings #35
Open
danielweck
wants to merge
20
commits into
develop
Choose a base branch
from
feature/epub3Bindings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
EPUB3 Bindings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Google Code samples does not resolve relative file paths correctly (moon-phase.xml data) so there is a TODO: pass absolute path to iframe src query parameter, not just the filename (otherwise the plugin XHTML cannot figure-out the base href).
Related issue: readium/readium-sdk#137 |
Feature branch / Pull Request is linked to: readium/readium-sdk#139 |
{ | ||
path = [NSString stringWithFormat:@"%@#%@", path, fragment]; | ||
} | ||
|
||
NSString * str = [[NSString stringWithFormat:@"%@/%@/%@", prefix1, _package.packageUUID, path] stringByAddingPercentEscapesUsingEncoding : NSUTF8StringEncoding]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: stringByAddingPercentEscapesUsingEncoding
must not be applied to query! (e.g. ampersand character gets escaped twice)
Conflicts: LauncherOSX/PackageResourceServer.mm
Conflicts: readium-sdk
Conflicts: LauncherOSX/LOXWebViewController.mm
…for testing small resources such as encrypted images
Conflicts: readium-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP