EPUB3 Bindings #35
Open
EPUB3 Bindings #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Google Code samples does not resolve relative file paths correctly (moon-phase.xml data) so there is a TODO: pass absolute path to iframe src query parameter, not just the filename (otherwise the plugin XHTML cannot figure-out the base href).
|
Related issue: readium/readium-sdk#137 |
|
Feature branch / Pull Request is linked to: readium/readium-sdk#139 |
| { | ||
| path = [NSString stringWithFormat:@"%@#%@", path, fragment]; | ||
| } | ||
|
|
||
| NSString * str = [[NSString stringWithFormat:@"%@/%@/%@", prefix1, _package.packageUUID, path] stringByAddingPercentEscapesUsingEncoding : NSUTF8StringEncoding]; |
There was a problem hiding this comment.
TODO: stringByAddingPercentEscapesUsingEncoding must not be applied to query! (e.g. ampersand character gets escaped twice)
Conflicts: LauncherOSX/PackageResourceServer.mm
Conflicts: readium-sdk
Conflicts: LauncherOSX/LOXWebViewController.mm
…for testing small resources such as encrypted images
Conflicts: readium-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP