Should we release 0.71.14?

[fortmarek]

Released, please refer to #90

---

Current Release: 0.71.13

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

1. facebook/react-native@f6107b6
2. facebook/react-native@5a671c1
3. facebook/react-native@647e09d
4. facebook/react-native@462d93d
5. facebook/react-native@8b1bf05
6. facebook/react-native@3eeee11
7. facebook/react-native@ce39931

Local commits to backport to main

[fortmarek]

Left-over pick from the 0.71.13 discussion: #78 (comment)

[fortmarek]

Picked ✅

[erinleigh90]

Can we backport facebook/react-native@462d93d to 0.71.14? (Removes the [email protected] dependency which has been flagged as vulnerable)

[fortmarek]

Picked ✅

[ken0nek]

Hi,

I would like to have this change for 0.71.14 (and also other version patches).

facebook/react-native#39060

[fortmarek]

This cherry pick is non-trivial due to merge conflicts (the file was moved and changed quite a bit since 0.71), so we will skip it for the current patch. @jpdriver, do you think you could prepare a PR to the 0.71-stable branch?

[ken0nek]

@fortmarek Thank you for handling the release!

so we will skip it for the current patch

Understood 👍

This is the patch I'm using for my project.

Extract extract_projects and exclude_i386_architecture_while_using_hermes from main.

diff --git a/scripts/cocoapods/utils.rb b/scripts/cocoapods/utils.rb
--- a/scripts/cocoapods/utils.rb
+++ b/scripts/cocoapods/utils.rb
@@ -53,22 +53,36 @@ class ReactNativePodsUtils
         end
     end

-    def self.exclude_i386_architecture_while_using_hermes(installer)
-        projects = installer.aggregate_targets
+    def self.extract_projects(installer)
+        return installer.aggregate_targets
             .map{ |t| t.user_project }
             .uniq{ |p| p.path }
             .push(installer.pods_project)
+    end

+    def self.exclude_i386_architecture_while_using_hermes(installer)
+        is_using_hermes = self.has_pod(installer, 'hermes-engine')

-        # Hermes does not support `i386` architecture
-        excluded_archs_default = ReactNativePodsUtils.has_pod(installer, 'hermes-engine') ? "i386" : ""
+        if is_using_hermes
+            key = "EXCLUDED_ARCHS[sdk=iphonesimulator*]"

-        projects.each do |project|
-            project.build_configurations.each do |config|
-                config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = excluded_archs_default
-            end
+            projects = self.extract_projects(installer)

-            project.save()
+            projects.each do |project|
+                project.build_configurations.each do |config|
+                    current_setting = config.build_settings[key] || ""
+
+                    excluded_archs_includes_I386 = current_setting.include?("i386")
+
+                    if !excluded_archs_includes_I386
+                        # Hermes does not support `i386` architecture
+                        config.build_settings[key] = "#{current_setting} i386".strip
+                    end
+                end
+
+                project.save()
+            end
         end
     end

---

do you think you could prepare a PR to the 0.71-stable branch?

Really appreciated. But I can prepare one if needed 🤝

[fortmarek]

@ken0nek if you can prepare a PR for 0.71, that will help us with adding it sooner 🙂 🙌

[ken0nek]

@fortmarek Created one facebook/react-native#39763 👍

[cipolleschi]

Fixes for Xcode 15

facebook/react-native@21763e8
facebook/react-native@0dbd621
facebook/react-native@8a5b2d6

[fortmarek]

Picked ✅

[fuekiin]

hi guys, is there an ETA for 0.71.14, since Xcode 15 is live today? Thanks!

[fortmarek]

We plan to release 0.71.14 next week.

[Yashtoddle]

Hi,
the Hermes is causing the issue for the large json files and that issued is open from the past 2 year , and now that issue is resolved it would be great if you add this update in the coming patch .
facebook/hermes@3213794

[fortmarek]

This won't make it to 0.71.14, we will look into it for the next patch.

[Yashtoddle]

what is the estimated date for the next patch , as I need this in my project urgently .

[lunaleaps]

@Yashtoddle There are merge conflicts getting this into 0.71. Can you make a PR against this branch https://github.com/facebook/hermes/tree/rn/0.71-stable and get the original author of facebook/hermes@3213794 to approve? Otherwise, the release crew is not equipped to support this pick

[cipolleschi]

Pick for Xcode 15:

• Update Xcode 15 patches to be more robust facebook/react-native#39710

[fortmarek]

Backported via facebook/react-native#39754

[cipolleschi]

Cherry-pick: facebook/react-native@ce39931

They released ActiveSupport 7.1.0 which breaks Cocoapods. 😮‍💨
This should fix the issue for all our users as they should use Bundler.

[fortmarek]

Picked ✅

[frankcalise]

Hello! Would it be possible to get facebook/react-native#38256 picked up in 71?