Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update fixture gemfile locks #1302

Merged
merged 3 commits into from
Aug 29, 2023
Merged

test: update fixture gemfile locks #1302

merged 3 commits into from
Aug 29, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 19, 2023

Summary

As part of shakacode/shakapacker#349 I have to update the lockfiles which would fail due to mini_racer so I had to regenerate them completely resulting in a failure because of a newer version of selenium-webdriver being used.

I figure ultimately this change is useful on its own because it'll impact anyone that needs to regenerate the lockfiles in future, so I might as well do a dedicated PR for it.

Other Information

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

@justin808
Copy link
Collaborator

@G-Rath should this get merged? Looks like mainly lockfile updates.

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 25, 2023

Yup yes please!

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 25, 2023

@justin808 that also goes for the shakapacker PRs I've got open btw :)

@justin808 justin808 merged commit 230e3f6 into reactjs:master Aug 29, 2023
5 checks passed
@justin808
Copy link
Collaborator

Thanks @G-Rath!

@G-Rath G-Rath deleted the update-lockfiles branch August 29, 2023 04:04
Judahmeek pushed a commit that referenced this pull request Jan 3, 2024
…talling (#1328)

* ci: don't allow lockfile updates when installing

* Revert "Merge pull request #1302 from G-Rath/update-lockfiles"

This reverts commit 230e3f6, reversing
changes made to f59b5b3.

* fix: update `mini_racer`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants