Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with docs/handbook/commands/canceling.md #90

Closed
SuperJMN opened this issue Dec 29, 2017 · 3 comments · Fixed by #856
Closed

Issue with docs/handbook/commands/canceling.md #90

SuperJMN opened this issue Dec 29, 2017 · 3 comments · Fixed by #856

Comments

@SuperJMN
Copy link

SuperJMN commented Dec 29, 2017

In the last part, where does the CancellationToken come from? where is it created?

EDIT: I successfully created a Cancel command with the docs :) Sorry, I didn't see that the CancellationToken was implicit in the StartAsync call.

BTW, there's a typo: sometimes the code says "cancelable" and sometimes it is "cancellable". Please, fix it.

@SuperJMN SuperJMN reopened this Dec 30, 2017
@RLittlesII
Copy link
Member

RLittlesII commented Aug 3, 2018

@SuperJMN The various forms of the word cancel have bothered me for years. Technically Cancelled and Canceled are both correct. This is a divergence in the English language. Because it is a CancellationToken I tend to agree that it should be cancelled in these instances.

https://www.dictionary.com/browse/cancelable

www.dictionary.com
Cancelable definition, to make void; revoke; annul: to cancel a reservation. See more.

@ghuntley
Copy link
Member

ghuntley commented Aug 6, 2018

We have a content style-guide over at https://reactiveui.net/contribute/content-style-guide/ 👍 It's based off the work that mailchimp open-sourced All content should be shaped based off the contents of the styleguide. The styleguide is the source of truth for color vs colour and how content is authored. If you think a section should be changed or burned in the style guide then send in the PR.

ReactiveUI is a composable, cross-platform model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming which is a paradigm that allows you to express the idea around a feature in one readable place, abstract mutable state away from your user interfaces and improve improve the testability of your application.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants