Problems with IDOM_FEATURE_INDEX_AS_DEFAULT_KEY #607
Replies: 5 comments 25 replies
-
|
The issues with Conreq Issues observed on
|
Beta Was this translation helpful? Give feedback.
-
|
Part of the reason you're not getting any warning is because you're passing children with |
Beta Was this translation helpful? Give feedback.
-
|
Makes sense. Is there any way for the framework to warn against using the unpack operator without keys? To my knowledge the answer is no, but thought I'd bring it up since someone else is likely to make the same mistake as me. If the answer is no, the docs should have some very simple examples of dynamic children passed down as a list, coupled with warnings against using the unpack operator. The current examples doesn't really fit the bill here due to the use of Also, from a technical perspective why do things seem to work as expected when |
Beta Was this translation helpful? Give feedback.
-
|
There's two approaches to checking for
I'm torn about the latter option because it might seem off-putting to people. |
Beta Was this translation helpful? Give feedback.
-
|
If |
Beta Was this translation helpful? Give feedback.
-
|
It actually should be possible to follow the AST within flake8 and identify unpack operators. I'll create an issue for this over on the idom-flake repo, but it'll be a while before I have time to develop that. |
Beta Was this translation helpful? Give feedback.
-
|
Created an issue #613 for this. |
Beta Was this translation helpful? Give feedback.
-
|
I've confirmed the resolution within 0.35.2 worked. |
Beta Was this translation helpful? Give feedback.
-
|
I've attempted using a list instead of the unpack operator for the debug tabs. The result was the VDOM dict being rendered as a string on the page. Is this an IDOM bug, or have I done the syntax wrong? Do I need to avoid constructing the list via unpack?
# Relevant LOCs
[
*( # Debug tabs
sidebar_group(
websocket,
state,
set_state,
group,
top_tabs=config._homepage.debug_nav_tabs,
)
for group in nav_tabs
if group == "Debug" and websocket.scope["user"].is_staff and DEBUG
)
],The original LOC looked like this |
Beta Was this translation helpful? Give feedback.
-
|
The unpack is definitely redundant, but since it's only redundant I'm not quite sure what's going on there. It looks like there's an enclosing parenthesis so maybe the VDOM element is in a tuple? Things seem to be working though. The following example renders correctly: from idom import component, html, run
@component
def Example():
return html.div(
[html.button(i) for i in range(3)],
html.button(0),
html.button(2),
html.button(2),
)
run(Example)
|
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed shortly: #614 |
Beta Was this translation helpful? Give feedback.
-
|
This solution works for resetting the default tab but is extremely inelegant, and for unknown reasons makes renders take upwards of 5 seconds. def tabbed_viewport( ... ):
...
prev_tabs, set_prev_tabs = idom.hooks.use_state(None)
all_tabs = (top_tabs or []) + tabs + (bottom_tabs or [])
if collections.Counter(prev_tabs) != collections.Counter(all_tabs):
set_prev_tabs(all_tabs)
set_tab_state(
TabbedViewportState(
_default_tab(top_tabs, tabs, bottom_tabs, default_tab=default_tab)
)
)
... |
Beta Was this translation helpful? Give feedback.
-
|
Can you create a minimal reproducible example and open a new discussion? It's a little hard to figure out what might be happening in context. |
Beta Was this translation helpful? Give feedback.
-
|
Sure. We could also do a tag up later tonight or right now if you want a quick demo. |
Beta Was this translation helpful? Give feedback.
-
|
Let's do now. |
Beta Was this translation helpful? Give feedback.
-
|
Invite has been sent |
Beta Was this translation helpful? Give feedback.
-
|
Gonna paste this here before I have to go. The minimum reproducible example will need the following (and a little more) @component
def parent():
state, set_state = idom.hooks.use_state( ... )
return div( child_wrapper(state, set_state), key=str(uuid4()) )
@component
def child(state, set_state):
child_state, set_child_state = idom.hooks.use_state( ... )
...
return something()
def child_wrapper(state, set_state):
return my_component(state, set_state)Will need to add in some buttons within the parent to switch between multiple children as well. |
Beta Was this translation helpful? Give feedback.
-
|
Was able to reproduce: #622 |
Beta Was this translation helpful? Give feedback.
-
Opening this as a discussion first since I'm unsure if this is specific to how Conreq is dynamically generating children.
It seems like
IDOM_FEATURE_INDEX_AS_DEFAULT_KEYis functionally broken. Conreq's homepage frequently fails to render tab changes now.Beta Was this translation helpful? Give feedback.
All reactions