Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @jest/globals dev dev to package.json #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mgcrea
Copy link
Contributor

@mgcrea mgcrea commented Nov 5, 2024

Summary:

Add missing @jest/globals dev dev to package.json

Changelog:

Test Plan:

@cortinico
Copy link
Member

Add missing @jest/globals dev dev to package.json

Why is this needed? Can you clarify?

@mgcrea
Copy link
Contributor Author

mgcrea commented Nov 5, 2024

Just created a new app and did have the error with the missing import from this line in my App.test.tsx:

import { it } from "@jest/globals";

But looking at the master it looks like it has been removed at some point.

I think it should be added back as it is required for TypeScript compatibility (see https://jestjs.io/docs/api)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants