Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Snap Kit React Native #737

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ramanpreetSinghKhinda
Copy link

πŸ“ Why & how

Add a new library https://www.npmjs.com/package/@snapchat/snap-kit-react-native
Pair: @safaiyeh

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

Updating the react-native-libraries.json file to add info for Snap Kit React Native npm repo.

Pair: @safaiyeh
@safaiyeh safaiyeh requested review from Simek October 7, 2021 00:38
@safaiyeh
Copy link
Member

safaiyeh commented Oct 7, 2021

Hey @Simek we wanted to launch Snap's official RN library on directory. Github cannot be public yet could it link to the NPM package

@Simek
Copy link
Member

Simek commented Oct 7, 2021

Hello guys, unfortunately we do not have a support for closed-source packages at this moment.

The GitHub repo and data extracted from the GitHub API about the repo and package are essential for getting metadata, scoring entry and it is a source of most of data which is displayed at the end.

@safaiyeh
Copy link
Member

safaiyeh commented Oct 7, 2021

Thanks @Simek there is a plan to open source it at some point. Will leave it to @ramanpreetSinghKhinda to update this addition when Snap gets it open sourced

@ramanpreetSinghKhinda
Copy link
Author

Thanks @Simek and @safaiyeh . We can update this after open sourcing but can we still have this pushed with the npm repo only?

@Simek
Copy link
Member

Simek commented Oct 7, 2021

can we still have this pushed with the npm repo only?

@ramanpreetSinghKhinda Unfortunately no, as you can see it breaks the validation and it would break the data fetch and the deploy.

There is no way around, besides refactoring a bunch of code and changing scoring methods to accommodate the lack of essential so far data.

@Simek Simek marked this pull request as draft October 7, 2021 20:05
@ramanpreetSinghKhinda
Copy link
Author

@Simek so will a private Github repo link work? If not, we can update this PR once we open source.

@Simek
Copy link
Member

Simek commented Oct 31, 2021

@Simek so will a private Github repo link work? If not, we can update this PR once we open source.

It will only work if you provide ACCESS_TOKEN for the scrapper, but ATM there is no such feature on the scrapper side and generally we would like to stick only to the open source projects.

Feel free to update the PR when the library will be open sourced and re-request the review. πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants