Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix made to handle if mode in command argument includes build flavor … #2324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sakiv
Copy link

@sakiv sakiv commented Mar 8, 2024

Summary:

This change addresses the bug #2323 reported for yarn react-native run-android with product flavor.

Test Plan:

Fix made locally and tested by installing on simulator, please refer below screenshot.

rn-cli-screenshot

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@sakiv sakiv requested a review from cortinico as a code owner March 8, 2024 02:25
@github-actions github-actions bot added the bugfix label Mar 8, 2024
// handle if selected task from interactive mode includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array
const variantFromSelectedTask = selectedTask
// handle if selected task from interactive mode, or mode from arguments, includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array
const variantFromSelectedTask = (selectedTask ?? args.mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szymonrybczak @adamTrz should we do the fallback here or set selectedTask to args.mode in non-interactive mode, if that makes sense?

@deepak-dpt
Copy link

If this is working fine, can we please merge it?

@zirho
Copy link

zirho commented Aug 4, 2024

This fixes my issue installing the app on a device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants