-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂️ Improve React Native onboarding experience #1936
Comments
@arushikesarwani94 , I'd like to take this one
|
Hi @arushikesarwani94, I'd like to work on this next
|
Inside codebase in cli/packages/cli-doctor/src/tools/runAutomaticFix.ts Lines 96 to 98 in 16ec7a3
cli/packages/cli-doctor/src/commands/doctor.ts Lines 257 to 260 in 16ec7a3
I think this also will be nice DevX improvement to properly handle these :) |
Updated the task list. |
Hi @arushikesarwani94, I'd would like to work on this
|
Thanks for your interest in this. As a pre-requisite to this one, it might be worth confirming the behavior of RN with Node 17 onwards. AFAIK Node 17 not being LTS isn't supported, however Node 18 is supported. |
Hi @arushikesarwani94 Can I take this one?
|
Hi @arushikesarwani94, I'd like to pick this one |
@Shubham1429 Would you still be interested in picking this up ? |
Hi @arushikesarwani94, sorry for the delay. I've been busy recently. I'll create a PR by Monday. |
There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
If anyone wants to grab some issue to fix, here's pretty easy one #2127 🙌 |
Description
Hi everyone!
This is an umbrella issue to collect a set of tasks aimed to improve the React Native onboarding experience. Onboarding experience as part of the DX pillar aims to improve user workflows like :
We believe that everyone would benefit by improving the core developer experience, hence this umbrella issue to help us cleanup and restructure some of our codebase.
How to Test
It’s crucial that you test the changes you submit. The proper way of doing this is:
node ./scripts/build.js && yarn build:debugger
yarn link
yarn link "@react-native-community/cli-doctor"
npx @react-native-community/cli doctor
The Tasks
The following is a list of tasks we think might aid the bootstrapping experience of React Native. The list is a living one: the more we improve with the situation, the more patterns we can discover. Whenever we found some pattern that we can add, we will attach this to the list.
If you want to tackle some specific task which is not listed, feel free to post a comment with a brief description of the task and I'll make sure to add it to the list of tasks so it is tracked.
Please comment below if you're willing to take the stance on any of those task and wait for a confirmation before start working on it. Please note that if you claim a task, but don't submit a PR within 2 week, we're going to free up that task for someone else.
cli-doctor :
Assigned to @tarunrajput Commit ce0ae4c
Java version check in versionRanges should be [11 - 18] (i.e. 19 is not supported).Commit 06ffb36Assigned to @tarunrajput
Node version check in versionRanges should be >= 18.Commit be7e6e2Assigned to @Shubham1429
feat : doctor should detect & report if packager is running correctly :Commit a2e90fdhttps://github.com/react-native-community/cli/blob/main/packages/cli-tools/src/isPackagerRunning.ts
Assigned to @tarunrajput
fix : Gracefully handle errors in doctor in case of TODOs
} catch (error) {
// TODO: log the error in a meaningful way
}
} catch (err) {
// TODO: log error
process.exit(1);
}
Commit 4650a8dcli/packages/cli-doctor/src/tools/runAutomaticFix.ts
Lines 96 to 98 in 16ec7a3
cli/packages/cli-doctor/src/commands/doctor.ts
Lines 257 to 260 in 16ec7a3
Assigned to @jeferson-sb
Open ended discussions :
During the “Installing Bundler” step, seemingly unnecessary warnings are printed, e.g.
error Ignoring unf_ext-0.0.7.6 because its extensions are not built. Try: gem pristine unf_ext —version 0.0.7.6.
This distracts from the actionable parts of init’s output. Reported in #1832The text was updated successfully, but these errors were encountered: