Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use monospace system font #537

Closed
elsassph opened this issue May 22, 2024 · 1 comment · Fixed by #539 or #540
Closed

Unable to use monospace system font #537

elsassph opened this issue May 22, 2024 · 1 comment · Fixed by #539 or #540

Comments

@elsassph
Copy link
Contributor

elsassph commented May 22, 2024

TextTextureRenderer has special logic to "detect" system fonts, but it only covers serif and sans-serif. Otherwise double quotes are added around the font name and this prevents using other system fonts.

This is limiting as a few other system fonts could be useful occasionally, in particular to render subtitles without including webfonts:

font-family: serif;
font-family: sans-serif;
font-family: monospace;
font-family: cursive;
font-family: fantasy;

https://developer.mozilla.org/en-US/docs/Web/CSS/font-family

@uguraslan uguraslan mentioned this issue Jun 4, 2024
2 tasks
@uguraslan uguraslan linked a pull request Jun 4, 2024 that will close this issue
2 tasks
@elsassph
Copy link
Contributor Author

Thanks @uguraslan - can you guys make sure this is also taken into account for Lightning 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant