Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn if no APPID and CLIENTID specified on LoggingDB initialization #58

Open
ricastell opened this issue Oct 20, 2017 · 2 comments
Open

Comments

@ricastell
Copy link

I have noticed that initializing the LoggingDB with the default APPID and CLIENTID results in poor performance in certain moments, maybe the timber instances allocated for these APPID/CLIENTID are not sufficient anymore?
In order to make it easier for the user to set his own credentials / inform him he may need to register his client as specified in the wiki, can we

  • check if APPID and CLIENTID are specified,
  • if they are not specified, try and read this info from a configuration.properties file in the same folder as the script (as one can already do with the java CLI)
  • if this fails, print a warning "using the default appid and clientid can result in poor performance...."
@rdemaria
Copy link
Owner

Thanks for reporting this, I forward this to CALS team to verify that this is the case. It seems a reasonable proposal anyway.

@rdemaria
Copy link
Owner

Can you contact me by email?

ricastell pushed a commit to ricastell/pytimber that referenced this issue Nov 13, 2017
@ricastell ricastell mentioned this issue Nov 13, 2017
ricastell pushed a commit to ricastell/pytimber that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants