New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling for MAXINT/MAXOBJ in various opcodes #264

Open

github-actions bot opened this issue Feb 10, 2024 · 0 comments

Labels

todo

github-actions bot commented Feb 10, 2024

Given we're 64-bit this is highly unlikely to ever be a concern for us, but

we also don't want to *crash* on obscene values, so impl that here.

moor/crates/kernel/src/vm/vm_execute.rs

Line 261 in 47435a1

// TODO: Handling for MAXINT/MAXOBJ in various opcodes

                    let (from, next_val) = {
                        let (to, from) = f.peek2();

                        // TODO: Handling for MAXINT/MAXOBJ in various opcodes
                        //   Given we're 64-bit this is highly unlikely to ever be a concern for us, but
                        //   we also don't want to *crash* on obscene values, so impl that here.

github-actions bot added the todo label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment