fix: check for resource.ErrNotExist error in check permission #808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem.
If a random ID is passed in the
CheckFederatedResourcePermission
APIresource
body. The API throws anInternal
error. And in the server logs, the error isresource doesn't exist
.After debugging, I found that we fetch the resource from the db, and it returns
ErrNotExist
error.This error was not handled in the API handler function.
This PR adds a check for the
resource.ErrNotExist
error. It also refactors the switch statement.