Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow limiting number of seats in plan #462

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

kushsharma
Copy link
Member

@kushsharma kushsharma commented Jan 19, 2024

  • seats limit can be configured via Behaviour Configuration in products.
  • 2 breaking changes are introduced
    • product credit amount is moved under config of product
    • to specify free credits awarded while subscribing to plan a new attribute on_start_credits is added
  • products table has a breaking change in db to get rid of credit amounts and replace it via config
  • allow filtering subscriptions by state
  • feat(frontier): max limit of product seat in plan proton#333

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:21pm

@coveralls
Copy link

coveralls commented Jan 19, 2024

Pull Request Test Coverage Report for Build 7586392529

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 41.794%

Totals Coverage Status
Change from base Build 7581737906: 0.3%
Covered Lines: 5987
Relevant Lines: 14325

💛 - Coveralls

- seats limit can be configured via Behaviour Configuration
in products.
- 2 breaking changes are introduced
  - product credit amount is moved under config of product
  - to specify free credits awarded while subscribing to plan
    a new attribute on_start_credits is added
- products table has a breaking change in db to get rid of credit
amounts and replace it via config

Signed-off-by: Kush Sharma <[email protected]>
@kushsharma kushsharma merged commit c01ec84 into main Jan 19, 2024
6 checks passed
@kushsharma kushsharma deleted the perseat-limit branch January 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants