Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding callback url after auth flow finishes #296

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

kushsharma
Copy link
Member

@kushsharma kushsharma commented Aug 13, 2023

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 4:32pm

@coveralls
Copy link

coveralls commented Aug 13, 2023

Pull Request Test Coverage Report for Build 5848415727

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 39.559%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1beta1/authenticate.go 0 11 0.0%
Totals Coverage Status
Change from base Build 5848395329: -0.05%
Covered Lines: 4338
Relevant Lines: 10966

💛 - Coveralls

- callback_urls is added in config that takes array of urls
- authorized_redirect_urls is added in config to whitelist endpoints
allowed to redirect user in browser after auth is finished in frontier
- cors_origin is now an array of strings

Signed-off-by: Kush <[email protected]>
@kushsharma kushsharma merged commit 2cae175 into main Aug 13, 2023
6 checks passed
@kushsharma kushsharma deleted the custom-auth-callback branch August 13, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants