Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename immutable context managers to *Context #28

Open
pabloem opened this issue Jun 15, 2022 · 4 comments
Open

Rename immutable context managers to *Context #28

pabloem opened this issue Jun 15, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@pabloem
Copy link
Collaborator

pabloem commented Jun 15, 2022

Specifuically RunnerContextManager and BundleContextManager are what we need to improve.

@pabloem
Copy link
Collaborator Author

pabloem commented Jun 15, 2022

Also, make RunnerContextManager fully immutable (will also help to persist it with ray.put) to avoid the cost of passing it around ever and over.

@wilsonwang371
Copy link
Contributor

let me c if i can start looking into this issue. @pabloem can you later give some help here if I take this item?

@pabloem
Copy link
Collaborator Author

pabloem commented Feb 8, 2023

I think it's fine if @flyingImer picks this up ? : )

@flyingImer
Copy link
Contributor

flyingImer commented Feb 20, 2023

@pabloem not sure I follow the RunnerContextManager one - not seeing any reference in the code base, am I missing anything here?

Do you mean RayRunnerExecutionContext and RayBundleContextManager ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants