Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: flake8 rule E231: Missing whitespace after ',', ';', or ':' #48107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: flake8 rule E231: Missing whitespace after ',', ';', or ':' #48107

wants to merge 1 commit into from
+5 −5

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Oct 19, 2024 •
edited
Loading

Why are these changes needed?

While running the pre-commit hook of flake8, the following error occurs if Python version is 3.12. It's because the version of flake8 is too old.

image

Related issue number

Closes #48060

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@win5923
fix: flake8 rule E231
cc2bafb 
Signed-off-by: win5923 <[email protected]>
@win5923
Copy link
Contributor Author

win5923 commented Oct 19, 2024

@MortalHappiness PTAL

MortalHappiness
MortalHappiness approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @rynewang

@pcmoritz pcmoritz enabled auto-merge (squash) October 19, 2024 18:12
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

@MortalHappiness MortalHappiness MortalHappiness approved these changes

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flake8 rule E231: Missing whitespace after ',', ';', or ':'
3 participants
@win5923 @pcmoritz @MortalHappiness