Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Adding in better framework for substituting logging handlers #48056

Conversation

omatthew98
Copy link
Contributor

Why are these changes needed?

This provides a more extensible framework around substituting logging handlers within the ray data logging configuration. This will allow more substitutions to be added with more ease and less cruft.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label Oct 16, 2024
Signed-off-by: Matthew Owen <[email protected]>
@scottjlee scottjlee enabled auto-merge (squash) October 16, 2024 23:23
@scottjlee scottjlee merged commit 059f4ba into ray-project:master Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants