-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs][KubeRay] Add doc for kubectl plugin #47851
base: master
Are you sure you want to change the base?
[Docs][KubeRay] Add doc for kubectl plugin #47851
Conversation
850969a
to
3c45a78
Compare
|
||
## Installation | ||
|
||
Please follow the instructions in the [KubeRay Kubectl Plugin](https://github.com/ray-project/kuberay/tree/master/kubectl-plugin) to install the plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We bundle the plugin binary into the KubeRay release now right? can we just download the bianry from the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like:
curl -LO https://github.com/ray-project/kuberay/releases/download/v1.2.2/kubectl-ray_v1.2.2_linux_amd64
cp kubectl-ray_v1.2.2_linux_amd64 /usr/local/bin/kubectl-ray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Let me create a PR in kuberay repo because the README.md is bundled into the tar file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue created: ray-project/kuberay#2449
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I think we can directly add this part into this page too:
curl -LO https://github.com/ray-project/kuberay/releases/download/v1.2.2/kubectl-ray_v1.2.2_linux_amd64.tar.gz
tar -xvf kubectl-ray_v1.2.2_linux_amd64.tar.gz
cp kubectl-ray ~/.local/bin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in f8a5a41
3c45a78
to
f8a5a41
Compare
Closes: ray-project#47849 Signed-off-by: Chi-Sheng Liu <[email protected]>
Add installation command for GitHub release Closes: ray-project#47849 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#47849 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#47849 Signed-off-by: Chi-Sheng Liu <[email protected]>
c87ec4a
to
e802c4b
Compare
Why are these changes needed?
See the description in the corresponding issue for details.
Related issue number
Closes: #47849
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.