Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda package for shadeMS #17

Open
sebastian-luna-valero opened this issue Apr 16, 2020 · 2 comments
Open

conda package for shadeMS #17

sebastian-luna-valero opened this issue Apr 16, 2020 · 2 comments

Comments

@sebastian-luna-valero
Copy link

Hi,

@jmoldon and I are insterested in having a conda package for shadeMS.

Having the following conda environment should ease the installation:

name: shadems

channels:
 - conda-forge
 - defaults

dependencies:
 - gxx_linux-64
 - boost
 - casacore
 - python
 - future_fstrings
 - colorcet
 - dask
 - datashader
 - holoviews
 - matplotlib
 - numpy
 - pandas
 - setuptools
 - pip
 - pip:
   - msutils

So now you only need to:

wget https://github.com/IanHeywood/shadeMS/archive/master.zip
bash ~/Files/devel/conda/Miniconda3-latest-Linux-x86_64.sh -b -p conda-install
source conda-install/etc/profile.d/conda.sh 
conda env create -f env.yml # env.yml contains the conda environment above
conda activate shadems
unzip master.zip 
cd shadeMS-master/
python setup.py install

Finally, when you run:

shadems

You get the following warnings:

/tmp/tmp.yz4vcKfK16/conda-install/envs/shadems/lib/python3.8/site-packages/shadems-0.1.0-py3.8.egg/ShadeMS/main.py:351: SyntaxWarning: "is" with a literal. Did you mean "=="?
/tmp/tmp.yz4vcKfK16/conda-install/envs/shadems/lib/python3.8/site-packages/shadems-0.1.0-py3.8.egg/ShadeMS/main.py:351: SyntaxWarning: "is" with a literal. Did you mean "=="?

Was shadeMS written for Python < 3.8?

I am happy to package shadeMS for conda, would you offer your help? If yes, one of the next requirements is to make a release of shadeMS either via GitHub or PyPI.

Best regards,
Sebastian

@o-smirnov
Copy link
Collaborator

Was shadeMS written for Python < 3.8?

I don't think any of us has tried it above 3.6 really. I fixed the SyntaxWarning just now and did a 0.1.0 release. We should probably get @Athanaseus to setup tests and push it to PyPI as well.

@sebastian-luna-valero
Copy link
Author

Thanks @o-smirnov

Having the 0.1.0 release on GitHub would be enough for the conda package so no need to push it to PyPI as well if you guys don want to. However, adding tests would be very much appreciated since they can be included in the conda recipe and will give us peace of mind for every update of the conda package.

Best regards,
Sebastian

@ratt-ru ratt-ru deleted a comment from codeFairOfficial Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants