Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ragavi integration #29

Open
o-smirnov opened this issue Feb 19, 2019 · 6 comments
Open

ragavi integration #29

o-smirnov opened this issue Feb 19, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@o-smirnov
Copy link
Contributor

Need to integrate ragavi into padre properly, in terms of:

  • adding to requirements.txt

  • sorting out nodejs virtualenv issues. Nodejs is needed by JS9 anyway, so it ought to be installed for both consistently.

  • sorting out image export from ragavi. Currently it's asking for selenium, then once that's pip installed, I get a RuntimeError: PhantomJS is not present in PATH.

@o-smirnov o-smirnov added the enhancement New feature or request label Feb 19, 2019
@o-smirnov o-smirnov self-assigned this May 22, 2020
@o-smirnov
Copy link
Contributor Author

I think this issue, as originally conceived, has been made largely irrelevant by the combination of HTML output in ragavi, plus HTML thumbnail rendering in radiopadre.

There is one lingering problem that deserves a look: #92 (comment)

Another way to address this @Mulan-94, maybe ragavi could be asked to generate a static preview.png file alongside the HTML plot? Radiopadre could then be tweaked to say hey, if I see foo.html and foo.html.preview.png together, then I don't need to render a thumbnail for the HTML, I can just use the supplied image directly.

@Mulan-94
Copy link
Collaborator

@o-smirnov , what do you think of this solution?

@o-smirnov
Copy link
Contributor Author

Which solution exactly? There's a lot of stuff on that page...

You're currently generating a standalone HTML document as per the first subsection, correct?

@Mulan-94
Copy link
Collaborator

Yes sorry, I mean generating HTML components that can be embedded in other HTML documents.

@o-smirnov
Copy link
Contributor Author

Ah, that's way more integrated than I was thinking. I like the standalone HTML fine for now, it's nice and standard and compatible with everything. I was just wondering if you can't export to PNG at the same time?

@Mulan-94
Copy link
Collaborator

It can be done with some additional set up ... I'll check how best this can be achieved smoothly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants