Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDA averager auto_corr detection case should use a tolerance test, rather than an equality test #308

Open
sjperkins opened this issue May 27, 2024 · 0 comments · May be fixed by #309
Open

BDA averager auto_corr detection case should use a tolerance test, rather than an equality test #308

sjperkins opened this issue May 27, 2024 · 0 comments · May be fixed by #309
Labels
bug Something isn't working

Comments

@sjperkins
Copy link
Member

  • Codex Africanus version: 0.3.7
  • Python version: 3.10
  • Operating System: 22.04

Description

max_abs_dist == 0.0 code path is reached in the binning code.

/cc @landmanbester
@sjperkins sjperkins added the bug Something isn't working label May 27, 2024
@sjperkins sjperkins linked a pull request May 27, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect auto-correlations via np.allclose, rather than equality ratt-ru/codex-africanus
1 participant
@sjperkins