Reduce runtime of gridding tests

[sjperkins]

• Codex Africanus version: 0.2.7
• Python version: 3.6
• Operating System: Ubuntu 18.04

Description

We've got two new gridders which is great. However, the test suite runtime has increased I guess by a third -- we're now looking at ~18 minutes for testing a single commit. Would it be possible to reduce the data sizes of some of these cases, without losing accuracy?

[landmanbester]

Woah, what is taking so long? The wgridder tests run in just under a minute on my laptop which I don't think is that bad

[sjperkins]

It's not a train smash because comprehensive tests are a good thing and it's better to have long-running test cases than not. Also, I think a minute is reasonable for a set of functionality.

Looking towards the future, the test suite is only going to take longer so its worthwhile considering how to pare its run time down.

[bennahugo]

My tests run in under 5 minutes on my desktop, primarily due to the computation of the DFT 272.85s user 6.62s system 115% cpu 4:01.33 total I guess we can cache this as a numpy array somewhere and download it to speed it up? The actual gridding/degridding time is well under a minute in total.

…

On Wed, Sep 23, 2020 at 3:59 PM Landman Bester ***@***.***> wrote: Woah, what is taking so long? The wgridder tests run in just under a minute on my laptop which I don't think is that bad — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#225 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4RE6VQFNEE67CESFYKBI3SHH5LVANCNFSM4RXCGPQQ> .

-- -- Benjamin Hugo PhD. student, Centre for Radio Astronomy Techniques and Technologies Department of Physics and Electronics Rhodes University Junior software developer Radio Astronomy Research Group South African Radio Astronomy Observatory Black River Business Park Observatory Cape Town

[landmanbester]

Is it now possible to just make tests that need the DFT smaller?

[bennahugo]

I've halved my runtime. If further optimization is needed I can cache the dft between test cases.

[sjperkins]

I've halved my runtime. If further optimization is needed I can cache the dft between test cases.

This is quite doable with a pytest fixture.

[bennahugo]

It appears that is deprecated (pytest-dev/pytest#3118) I will need to dump it into a file somewhere