Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for manual masking... #6

Open
cyriltasse opened this issue Nov 2, 2020 · 8 comments
Open

Add option for manual masking... #6

cyriltasse opened this issue Nov 2, 2020 · 8 comments

Comments

@cyriltasse
Copy link
Collaborator

Checking how this goes, I was thinking in the original MakeMask there is an option for manual masking - that proved to be quite useful in some cases... Would be nice to add this... @o-smirnov is the plan to remove MakeMask from DDF?

@o-smirnov
Copy link
Contributor

We don't have to rush to remove it, but we can let it die slowly if this has all the functions...

@o-smirnov
Copy link
Contributor

@Athanaseus added a GUI option... is that what you mean by manual masking?

@Athanaseus
Copy link
Member

The GUI currently just view the immediate mask created. Here I had in mind to use bokeh freehand annotation feature to extend/remove regions manually. Not sure if this is what you would like to have?

@IanHeywood
Copy link
Collaborator

Here's my $0.02:

I probably wouldn't use a feature that was simply a viewer, but I think an interface for manually editing masks is an excellent idea. I've used GIMP for this purpose a few times, but that's a fiddly process.

Although if the GUI introduces problems with running this on remote machines then I'd rather have no GUI compoent.

@o-smirnov
Copy link
Contributor

Although if the GUI introduces problems with running this on remote machines then I'd rather have no GUI compoent.

Well the GUI components can be imported on demand, so it shouldn't cause any problems remotely. That said, see also #11 that I just opened.

@landmanbester
Copy link
Collaborator

I probably wouldn't use a feature that was simply a viewer, but I think an interface for manually editing masks is an excellent idea.

Seconded, this would be epic. I have tried something like this using OpenCV but I gave up pretty quickly. Always meant to get back to it

@cyriltasse
Copy link
Collaborator Author

@Athanaseus added a GUI option... is that what you mean by manual masking?

Yeah perhaps... In MakeMask I was using ds9 regions to select/unselect regions to mask...

@twillis449
Copy link

twillis449 commented Apr 3, 2021

Text at the bottom :)
breizorro_mask
manual_mask

For my own purposes I have now developed a system where one can select which of the breizorro mask areas you want to work with, or if you want to specify which area of a field you wish to sum up you can specify the area yourself. In this example shown here, I can just click on the blue breozorro contour (1st figure) which can then get sent downstream for further ananlysis, or if I don't like the breizorro output I can specify a region of the source image (2nd figure).

I am setting up a git repository for my code and will check the code in next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants