Swap endian-ness in tools on big endian host #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
May 1, 2021
| @@ -17,44 +17,45 @@ | |||
|
|
|||
| #define PT_LOAD 0x00000001u | |||
|
|
|||
| /* Note, only little endian ELFs handled */ | |||
There was a problem hiding this comment.
Would it make sense for elf2uf2 and picotool to both pick up a common elf.h header from pico-sdk? 🤷
(These PRs are a bit over my head, so apologies if that's a silly suggestion.)
|
I have raspberrypi/pico-sdk#329 applied to the Debian packaging of pico-sdk and am thus also interested in this patch for picotool. Can you think of a nice test case for picotool which would not require hardware and would fail on big endian machines? Something I can run as part of the Debian autopkgtests to make sure this works? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on raspberrypi/pico-sdk#329.