Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Changed breakpoints | Frontend fixes checkout #125

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Roene-JustBetter
Copy link
Member

@Roene-JustBetter Roene-JustBetter changed the title Changed breakpoints | Frontend fixes checkout [3.x] Changed breakpoints | Frontend fixes checkout Nov 5, 2024
@@ -6,7 +6,7 @@

@section('content')
<div class="container">
<x-rapidez-ct::layout class="mt-8 sm:mt-14">
<x-rapidez-ct::layout class="mt-8 sm:mt-14" v-cloak>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the progress bar cause layout shifts? I thought it didn't use JS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want v-cloak on the separate items instead of the wrapper?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what's shifting

@royduin royduin merged commit 1597a1d into feature/rapidez-v3 Nov 5, 2024
1 check failed
@royduin royduin deleted the feature/rapidez-v3-frontend-fixes branch November 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants