-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarkerCluster not working properly in Streamlit 1.34 onwards #222
Comments
Spent a bit of time figuring out the bad commit upstream with It seems to be a fairly innocuous change, but somehow breaks the spiderfy functionality. |
Wow, thanks for doing that digging! I'll reach out to the streamlit team and see if they have any insights. |
thanks @blackary @randyzwitch! I ended up creating a .tar.gz of 1.38 without that particular commit, and it seems to be working well for my app: https://hdb-kaki.streamlit.app/Town_Analysis To reproduce, you can try running the script above with Streamlit 1.38 (the spiderfy functionality should be missing). Then drop that specific commit from the Streamlit commit history, recompile using Otherwise if it's useful, I created a demo branch with the original bug: https://github.com/benjamin-awd/hdb-kaki/tree/folium-regression-demo Btw, had no issues running on Safari even without that commit |
Hey @randyzwitch @benjamin-awd ! Thanks for letting us know. I'm having trouble figuring out what is going on from Streamlit's side that could be causing the issue. We did notice that v0.20.0 works but v0.20.1 does not work. Looking at the Network logs I see the Marker Cluster is inserted after the map information (that all being said, I see scripts duplicated multiple times). This leads me to think this might be tied to this change surrounding the dynamic load of the JS instances. |
Interesting that this might both be a streamlit and a streamlit-folium issue |
It seems that Streamlit version 1.34 introduced some kind of regression for Folium -- specifically it disables the Spiderfy functionality in MarkerCluster (and I think any related interactivity)
Expected
(on click)
Current
To reproduce
The text was updated successfully, but these errors were encountered: