-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to suppress bell in Terminus with Sublime Text #390
Comments
It is only a windows issue? Anyway, it could be fixed by overriding some methods in |
I meant it doesn’t produce a bell sound on macOS Terminus. It certainly makes a noise in the system Terminal. I tracked upstream, it seems that the default implementation is empty |
Found it. rprichard/winpty#147 It is an windows specific issue because of the use of winpty on windows. There is a workaround in an upstream bug. Ultimately, we want to move to newer version of pywinpty which uses the ConPTY instead of winpty. |
Besides the workaround, there is nothing we could do here. The signal was intercepted by winpty and the sound was made even before it reaches Terminus. |
For the time being, I've switched from KSH to CSH on the target machine since it can be configured not to emit bell characters as a workaround. Ideally, the terminal should be able to handle this though. Thanks for the footwork. |
Description:
Currently, when using Terminus with Sublime Text, there is no option to suppress the bell sound when a shell generates it. This is particularly problematic when connecting over SSH or when running shell commands that produce a bell character, such as when a command is completed, or when there is an error. The lack of an option to suppress the bell can be disruptive and distracting to users.
Suggested Solution:
Suggest adding an option to Terminus that would allow users to disable the bell sound when it is generated by the shell. This could be a simple boolean in the Terminus settings that when true, would suppress the bell sound. This would provide users with greater control over the sound settings in Terminus and improve their overall user experience.
Steps to Reproduce:
echo ^G
and press Enter where^G
is entered by pressing Ctrl and G simultaneously.echo -e '\a'
and press Enter.Note that bell characters are regularly generated in many shells when failing to auto-complete, attempting to back-space before the beginning of a line, etc. It is quite distracting.
Expected Result:
The bell sound is not played when the option to suppress it is enabled.
Actual Result:
The bell sound is played even when there is no option to suppress it.
Environment:
Additional Information:
This feature request would greatly benefit users who work with Terminus on a regular basis, particularly those who connect to remote servers via SSH or work with shell commands that produce a bell character. The ability to suppress the bell sound would make it easier to focus on their work without being disrupted by unnecessary sounds.
The text was updated successfully, but these errors were encountered: