Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative values in sqdev? #44

Open
rodlaje opened this issue Aug 19, 2022 · 0 comments
Open

Negative values in sqdev? #44

rodlaje opened this issue Aug 19, 2022 · 0 comments

Comments

@rodlaje
Copy link

rodlaje commented Aug 19, 2022

Hi there again,
I'm using the option least_squares_diff in latent_infer (nice one btw). I've noticed that, after doing xm = np.diff(xm,axis=0) in line 3654 of inference.pyx (function _obtain_square_dev_for_lat_traj_diff) the variable xm can end up with negative values which are added to sqdev when they are used in the denominator to normalize it. This is bad because sqdev could decrease towards minus infinity in search of a minimum. Shouldn't xm_red in the denominator of line 3658 be surrounded by np.abs() or something?
Rodrigo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant