Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#217 Removing redirect from pages, produces infinite redirect in localhost #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eatskolnikov
Copy link

What changed?

The redirects headers were removed from some pages given they were creating an infinite redirect loop when working from localhost.

The issue seems to be that the internal routing from the jekyll serve command get's confused because we have both a folder and an html file the same name as the route. It seems to be taking the folder route as priority but then inside the folder there is an index.html file that tries to redirect to the .html file.

It probably works on the server side because they are using nginx and the routing order is handled differently/correctly.

The only consequence of this change is that we would have the / at the end of the affected pages routes.

A few images to illustrate the issue:

confusing_routing

confusing_routing2

@rafaelfranca
Copy link
Member

The only consequence of this change is that we would have the / at the end of the affected pages routes.

That is exactly what were are trying to avoid by having this redirect. Isn't any other way to fix this issue?

@tgaeta
Copy link

tgaeta commented Jun 18, 2024

I'm curious about what introduced this bug. If @rafaelfranca wants to avoid the trailing slash, maybe we can revert the change that caused this issue as a compromise? Either way, having an infinite loader for multiple pages locally is less than ideal.

Also, this doesn't fix other pages experiencing the same issue:

  • category/releases/
  • category/news/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants