Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: rubygems >= 3.2.0 for Platform#match_gem? #289

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

flavorjones
Copy link
Member

Closes #286

@flavorjones flavorjones force-pushed the flavorjones-platform-match-gem-dep branch from d82fa28 to 1cb3aaa Compare October 27, 2023 18:56
@flavorjones flavorjones force-pushed the flavorjones-platform-match-gem-dep branch from 1cb3aaa to 44b470d Compare October 27, 2023 19:12
@flavorjones flavorjones merged commit 6bf95b3 into main Oct 27, 2023
20 checks passed
@flavorjones flavorjones deleted the flavorjones-platform-match-gem-dep branch October 27, 2023 19:19
@henrikbjorn
Copy link

@flavorjones This kind of sucks for those that aren't quite able to upgrade the rubygems platform. This means that even though tailwind has new releases, we won't get the update through this gem.

why not bump the minor version with this? Or even a new Major, since it is a BC break?

@flavorjones
Copy link
Member Author

@henrikbjorn That might have been a good idea, but I can't go back in time and fix it now. I'd suggest pinning your app to 2.0.30 if you can't upgrade rubygems.

Out of curiosity, can you share more about your situation and why you're not able to upgrade? Rubygems 3.2.0 is over three years old at this point I think should be shipped in all versions of Ruby that are not EOL.

@henrikbjorn
Copy link

@henrikbjorn That might have been a good idea, but I can't go back in time and fix it now. I'd suggest pinning your app to 2.0.30 if you can't upgrade rubygems.

Out of curiosity, can you share more about your situation and why you're not able to upgrade? Rubygems 3.2.0 is over three years old at this point I think should be shipped in all versions of Ruby that are not EOL.

Can't be specific.

But I think some might have old infrastructures, or stuck with gems that haven't been updated in a while etc.

How about doing a point release for 2.0.x that checks for 'respond_to?` or something?

@flavorjones
Copy link
Member Author

There are two known workarounds:

  • upgrade rubygems
  • pin this gem to 2.0.30

Because there are ways around this issue, and because this issue affects so few people, writing and testing a third workaround and making a release feels like a relatively low priority for me, at least without additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.0.31 Fails on ruby 2.7.x
2 participants